acfr / comma

generic c++ libraries
Other
27 stars 16 forks source link

csv-time-join - Unexpected behavior at border time stamps #60

Open vendall opened 9 years ago

vendall commented 9 years ago

I'm having an unexpected issue with csv-time-join, though this may be a feature and I'm not fully understanding the utility.

Here is what I want to do:

Inputs sensor_data.bin - standard timestamped sensor bin file (hyperspec in my case but irrelevant to this issue) timestamps.bin - list of time stamps

Goal I want to grab from sensor_data.bin any data within n seconds of the timestamps in timestamps.bin.

Current Method sensor_data.bin | csv-time-join 'timestamps.bin;binary=t;fields=t' - --binary='t,3ui,158112w' --fields=t --nearest --bound=n

Current Outcome This seems to work for all timestamps in timestamps.bin, except for the first and last. For the first one it only outputs data with timestamps up to n seconds larger (inclusive), and for the last one it only outputs data with timestamps up to n seconds smaller (not inclusive).

Is this behavior expected? If yes, can I achieve what I want with csv-time-join?

Cheers, Alex.

vlaskine commented 9 years ago

probably the quickest would be to take a look at your desk and decide what to do (even if it is a bug, i can think of a quick workaround)

when would it be a good time?

vendall commented 9 years ago

Hi Seva, do you want to take a look at 12 tomorrow?

I can probably make it work in combination with cvs-time-delay, but I thought I'd ask first in case I'm missing something (or in case it's a genuine bug).

vlaskine commented 9 years ago

csv-time-delay is exactly the workaround i kept in mind, however let us have a chat at 12 tomorrow (on tuesday); i will go over to your desk

if it is a bug (as it seems so far), we will come up with a simple way to reproduce it and identify the right behaviour

if, less likely, it is a subtle feature, i will update --help