search

achambers / ember-cli-deploy-original

An Ember-CLI addon for lightening fast deployment of applications
77 stars 18 forks source link

Support for EMBER_ENV #66

Open jrhe opened 9 years ago

jrhe commented 9 years ago

It would be good to be able to set EMBER_ENV to the environment being used for ember deploy commands like you can with the built in ember-cli commands. I'm surprised that ember-cli does not do this for add ons automatically.

i.e.

ember build --environment production ember deploy:assets --environment production ember deploy:index --environment production ember activate --environment production

vs

ember build; ember deploy:assets; ember deploy:index; ember activate

Any reason that ember activate isn't namespaced in deploy?

I will attempt to do it if I get chance.

Thanks for a great project :).

achambers commented 9 years ago

Hey mate, great idea. Thanks for the input. Feel free to submit a PR for this if you get to it before I do.

As for the namespacing, to be honest I kind of felt ember deploy:activate didn't really make sense..... ember deploy:index makes sense.....We are deploying the index. Where as deploy:activate doesn't really make sense....We are not deploying the activate....

But I guess it depends on which way you look at it. If the deploy is simply seen as a namespace then yeh, it probably should be. I was more trying to get it to read nicely and like plain English.

Anyway, maybe we should look at 'namespacing' it with 'deploy'

achambers commented 9 years ago

ember-cli-deploy is in the process of merging with ember-deploy. Therefore, no more changes will be made to this repo. Please see the README for more details. /cc @jrhe