search

achanda / ipnetwork

A library to work with CIDRs in rust
Apache License 2.0
121 stars 38 forks source link

Add a deprecation note to NetworkSize #104

Closed achanda closed 4 years ago

achanda commented 4 years ago

https://github.com/achanda/ipnetwork/issues/102 cc @lucab @vorner

achanda commented 4 years ago

Leaving this open for a while so that anyone gets a chance to comment.

lucab commented 4 years ago

I'm not using this interface (and I'm actually happy with the current API), but maybe you'd want to first land the new methods and then deprecate this? Or is your plan to re-use the same exact function name?

achanda commented 4 years ago

I was hoping to use the same names, so planning to:

  1. Merge this PR
  2. Cut a release
  3. Merge another PR to change the API
  4. Cut a new release
achanda commented 4 years ago

I think I should take a step back to figure out a best way to deprecate these. I will close this one and get back to this when I have a plan.