achanda / ipnetwork

A library to work with CIDRs in rust
Apache License 2.0
121 stars 38 forks source link

This crate's Cargo.toml claims to support serde < 1.0 but it doesn't #132

Closed saethlin closed 4 years ago

saethlin commented 4 years ago

This crate's Cargo.toml says serde_derive = ">=0.8.0, <2.0", but this crate does not compile if Cargo selects serde 0.8.

It just happens to work usually because cargo publish runs cargo update, and people tend to keep packages up to date. I've encountered this often because I build this crate in a project that contains another dependency that only supports serde 0.8, and sometimes Cargo assigns serde 0.8 to this crate as well. This results in suprious build errors.

I'm happy to write a PR to fix this, but the version specification ">=0.8.0, <2.0" is so specific and unique that I'd like to understand why this came about first.