Non-USD lot currency confuses valuation logic

achannarasappa / ticker

Terminal stock ticker with live updates and position tracking

GNU General Public License v3.0

4.94k stars 264 forks source link

Non-USD lot currency confuses valuation logic #223

Closed yznts closed 2 years ago

yznts commented 2 years ago

Describe the bug When lot currency is not USD (but USD selected as a base display currency), valuation logic still thinks it's USD.

To Reproduce Steps to reproduce the behavior:

Add any non-USD lot

Expected behavior Take into account lot currency.

Screenshots

Environment (please complete the following information):

OS: Mac
Terminal: iTerm
Terminal Version: 3.4.15
ticker Version: 4.5.1

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

deroshkin commented 2 years ago

After messing around with this issue, it seems that it's caused by Yahoo incorrectly formatting the London stock exchange quote currency as GBp instead of GBP, which causes currency conversion error. The same error occurred with London stocks when using CAD as display currency.

I've submitted a pull request #231

achannarasappa commented 2 years ago

Thanks again for the fix @deroshkin this is addressed in the latest release