achannarasappa / ticker

Terminal stock ticker with live updates and position tracking
GNU General Public License v3.0
4.94k stars 264 forks source link

Crypto issure - open and close prices are the same #226

Closed brolal closed 2 years ago

brolal commented 2 years ago

Describe the bug Prev. Close and Open are the same for crypto

To Reproduce Steps to reproduce the behavior: config file: show-summary: true show-tags: true show-fundamentals: true show-separator: true show-holdings: true interval: 5 currency: USD currency-summary-only: false watchlist:

Expected behavior the open and close should be diffrent

Screenshots Screenshot from 2022-06-25 01-51-36

Environment (please complete the following information):

Additional context When adding stocks, it works fine

achannarasappa commented 2 years ago

Thanks for calling this issue out - these values are the same because crypto markets do not close and thus do not have an Open price. Even that Prev. Close field is a misnomer since the market never closes.

I've seen the Prev. Close property set to the value of the crypto asset 24 hours ago in other applications that show market data for crypto assets so I've done the same in ticker. I'm open to ideas or suggestions on a clearer way to communicate that property.

For the Open price, I've made a change in the latest release that hides this property for assets that do not have an open price such as crypto assets for clarity.