search

achannarasappa / ticker

Terminal stock ticker with live updates and position tracking
GNU General Public License v3.0
4.94k stars 264 forks source link

Ticker hangs at startup #237

Closed ajgringo619 closed 1 year ago

ajgringo619 commented 1 year ago

Describe the bug Ticker screen opens blank, never updates any configured assets

To Reproduce Steps to reproduce the behavior:

  1. Start ticker --config $HOME/.config/ticker/ticker.yaml
  2. Header/footer appear, but no stock data

Environment (please complete the following information):

Additional context When I run this command (from your source) - curl "https://query1.finance.yahoo.com/v7/finance/quote?lang=en-US&region=US&corsDomain=finance.yahoo.com&fields=regularMarketPrice,currency&symbols=IBM" - it works. https://finance.yahoo.com works as expected. A data test with yfinance also works, so this doesn't seem like a connection problem.

This has been working for months (updated on 2022-09-17), up until about an hour ago.

achannarasappa commented 1 year ago

Thanks for reporting this! It looks like there was a change in the schema of the data being returned by the Yahoo. Having a closer look to see what needs to be changed

ajgringo619 commented 1 year ago

Thanks for the quick response. I use a small Python script to auto-create ticker's yaml file from a spreadsheet, so I thought maybe something there had changed.

achannarasappa commented 1 year ago

Just released v4.5.5 which should fix the majority of broken cases. There's likely a few I missed which will become evident over time e.g. the indicator for market state change from POST to POSTPOST

I'll keep this issue open for a few days in case there's reports of other similar issues.

ajgringo619 commented 1 year ago

Working as expected - thanks a bunch! Should we leave this open for a bit in case others have different issues?

eriknh commented 1 year ago

Thanks for the quick fix.

jayray-git commented 1 year ago

Test fail when running

go test ./...

ticker-test-fail.txt

Harpo3 commented 1 year ago

Using 4.5.5-1 and same issue as OP.

achannarasappa commented 1 year ago

@Harpo3 is the issue you're seeing with tests failing or that ticker is hanging? The test failure issue was just addressed in a recent commit.

Harpo3 commented 1 year ago

@Harpo3 is the issue you're seeing with tests failing or that ticker is hanging? The test failure issue was just addressed in a recent commit.

Running the AUR version in Arch Linux. Ticker starts but there is nothing in the display. It used to display my positions and quotes.

achannarasappa commented 1 year ago

Please check again - the AUR version is not maintained by me and it was likely took some time for the new version to be published.

Closing this issue for now but will reopen if there is still an active issue.