search

achaudhry / adhan

Raspberry Pi Adhan Clock
39 stars 25 forks source link

Friday surah baqarah #12

Open rehanhaider opened 3 years ago

rehanhaider commented 3 years ago
  1. Arranged the app in a more modular fashion
  2. Changed the config management to the python standard ConfigParser library
  3. Added an option through "settings.ini" to play Surah Baqarah on Fridays
achaudhry commented 3 years ago

I just merged a PR that was created prior to yours which has created some conflicts. Could you please resolve conflicts and re-submit the PR? Thanks!

rehanhaider commented 3 years ago

Have resolved the conflicts now.

achaudhry commented 3 years ago

Happy to merge most of your changes but not convinced that we should add the Surah Baqrah feature. See my comments inline. Thanks!

rehanhaider commented 3 years ago

In my view you should reject/close the PR.

All the changes are very specific to what I need and I agree it probably doesn't go with your vision. On 16 Jul 2021, 1:37 AM +0530, Abrar Chaudhry @.***>, wrote:

Happy to merge most of your changes but not convinced that we should add the Surah Baqrah feature. See my comments inline. Thanks! —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

achaudhry commented 3 years ago

Are you sure brother? You did a lot of work and I'd hate to not incorporate it. If you want to take out the Surah Baqrah part, I'm more than happy to merge the rest of it.

rehanhaider commented 3 years ago

Nah it's OK, my OCD made me organise this a bit better, but I didn't change any functionality so continue working seamlessly for everyone.

I'll continue using my own fork with customisations I made as per my need.