achave11-ucsc / brca-website

Apache License 2.0
0 stars 0 forks source link

Start and ending position offset #14

Closed achave11-ucsc closed 8 years ago

achave11-ucsc commented 8 years ago

Create a function and test that allows for internally making the -1 offset to satisfy the query at the request layer.

david4096 commented 8 years ago

https://github.com/ga4gh/schemas/blob/7e586839dceb30c37c4a18ec09ad9bfab6a01b02/src/main/proto/ga4gh/variant_service.proto#L93

  // Required. The beginning of the window (0-based, inclusive) for
  // which overlapping variants should be returned.
  // Genomic positions are non-negative integers less than reference length.
  // Requests spanning the join of circular genomes are represented as
  // two requests one on each side of the join (position 0).
  int64 start = 4;

  // Required. The end of the window (0-based, exclusive) for which overlapping
  // variants should be returned.
  int64 end = 5;
achave11-ucsc commented 8 years ago

resent merge, also included the function which allowed for creating offset in two instances, to query the database, as well as illustrate the shift in the opposite direction when the request is being serviced. Reference issue #15