search

achedeuzot / ueberauth_auth0

Auth0 OAuth2 strategy for Überauth.
https://hexdocs.pm/ueberauth_auth0
MIT License
71 stars 46 forks source link

Give implementer the choice about 403s coming from Auth0 #174

Closed maciej-szlosarczyk closed 3 years ago

maciej-szlosarczyk commented 3 years ago

In case a user enters their own code and hits the callback URL, therequest will always raise OAuth2.Error. This is not ideal, as it means a 500 being shown to the user.

What should happen instead, is that we populated the ueberauth_failure assigns and the implementer can decide what to show to the the user.

achedeuzot commented 3 years ago

Hi @maciej-szlosarczyk !

Thanks a lot for this pull request :) It's a nice improvement to have better control on the plugin behavior. I'll merge it soon-ish after upgrading some dependencies, and as it's a breaking change, I'll bump the version to 2.0.0 when merging this.

Thanks again !

maciej-szlosarczyk commented 3 years ago

Amazing, thank you @achedeuzot!