achedeuzot / ueberauth_auth0

Auth0 OAuth2 strategy for Überauth.
https://hexdocs.pm/ueberauth_auth0
MIT License
71 stars 46 forks source link

Handle OAuth2 error in `handle_callback!/1` #245

Open kevinam99 opened 1 year ago

kevinam99 commented 1 year ago

Based on issue https://github.com/achedeuzot/ueberauth_auth0/issues/193. Saw that this issue has been technically resolved in the discussions but the fix hasn't been added yet so I thought of creating the PR.

Added this fix based on @benkimpel's comment https://github.com/achedeuzot/ueberauth_auth0/issues/193#issuecomment-984808643

Hope this is still relevant, though

benkimpel commented 1 year ago

Based on issue https://github.com/achedeuzot/ueberauth_auth0/issues/193. Saw that this issue has been technically resolved in the discussions but the fix hasn't been added yet so I thought of creating the PR.

Added this fix based on @benkimpel's comment https://github.com/achedeuzot/ueberauth_auth0/issues/193#issuecomment-984808643

Hope this is still relevant, though

Cool. Thanks, @kevinam99. I never did get around to opening that PR. Sorry, @achedeuzot, for not delivering on that.

kevinam99 commented 1 year ago

Friendly nudge @achedeuzot

achedeuzot commented 1 year ago

I'll be checking that later this week hopefully, I've got a 100% packed schedule 🥲

kevinam99 commented 1 year ago

Oh :( No problem, I understand. Let me know if there's anything I could do