search

acheronfail / repgrep

An interactive replacer for ripgrep that makes it easy to find and replace across files on the command line.
Apache License 2.0
267 stars 4 forks source link

Fix Windows binaries generated on each release #61

Closed acheronfail closed 1 year ago

acheronfail commented 3 years ago

Right now it doesn't build Windows binaries.

It should.

sergeevabc commented 3 years ago

Err… Could you update the community about the progress, please?

cpkio commented 3 years ago

The project seems to be abandoned…

dufferzafar commented 3 years ago

@acheronfail Could you please explain what would one have to do to get Windows builds working? Are the libraries that repgrep depends on available on Windows?

acheronfail commented 1 year ago

Honestly I don't know. I'm very unfamiliar with development on Windows, and am really wanting someone with some knowledge about building for Windows targets to help out.

Since I don't use Windows myself, this is fairly low on the priority list, but I do hope to get around to it if life permits...

cpkio commented 1 year ago

it builds perfectly on windows with cargo build --release. that's a CI issue, not code.

acheronfail commented 1 year ago

Alright, I ran this on Windows 11 in a VM, and can confirm the issue is in CI.

CI fails when trying to copy target/x86_64-pc-windows-msvc/release/rgr.exe.

I replicated what the CI does though (installing cross and using that to compile, etc) and in the VM the file target/x86_64-pc-windows-msvc/release/rgr.exe exists, so not entirely sure what the issue is here. :thinking:

cpkio commented 1 year ago

@acheronfail maybe the generated completion files fail somewhere?