Open GoogleCodeExporter opened 9 years ago
I don't really want to reinvent the wheel here. IMHO we should reuse the side
by side diff logic from Gerrit, but of course that's currently impossible
because Gerrit uses GWT, and does various other things wrong. So, first let's
fix Gerrit.
Original comment by dborowitz@google.com
on 11 Nov 2012 at 11:19
Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do
that too: not too much fancy JS, hopefully largely pasting it in, I haven't
looked. Even if not, we should be able to reuse more code because it's just the
server-side stuff (serving diff info), no more GWT.
Original comment by dborowitz@google.com
on 19 Jun 2013 at 12:26
For reference, I requested this via email as something that I think is
important for parity between ViewVC and gitiles if Chromium is moving from the
former to the latter.
Original comment by pkasting@chromium.org
on 5 May 2014 at 4:26
Can/should it be optional? I personally prefer the single format.
Original comment by b.kelemen@samsung.com
on 6 May 2014 at 10:58
Original comment by mmoss@chromium.org
on 26 Aug 2014 at 12:06
Any update on the prospects for this?
Original comment by mmoss@chromium.org
on 26 Aug 2014 at 12:08
Issue chromium:384604 has been merged into this issue.
Original comment by benhe...@google.com
on 26 Aug 2014 at 12:16
Nope. :(
IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium
project. So a new side by side view needs to be built from scratch in Gitiles,
but that work hasn't been estimated or scheduled.
Original comment by sop@google.com
on 26 Aug 2014 at 12:21
Original issue reported on code.google.com by
dborowitz@google.com
on 11 Nov 2012 at 11:17