search

achille-roussel / nanomsgxx

Nanomsg binding for C++11
MIT License
115 stars 35 forks source link

_LIBCPP_VERSION is not a good way to check for C++11 support #16

Closed liamuk closed 6 years ago

liamuk commented 6 years ago

In message_streambuf, this library uses the presence of the macro _LIBCPP_VERSION to check if rvalue references are supported by the compiler.

This works only for clang. Compiling with this library using gcc and using the macro guarded functions in message_streambuf doesn't work, even if the version of gcc supports rvalue references.

achille-roussel commented 6 years ago

Thanks for the feedback. Honestly I think we could get rid of this check all together, it’s 2018 and compilers have been supporting C++11 for ages.

Would you have some time to send a PR and address this issue? Feel free to suggest an alternative approach as well.

liamuk commented 6 years ago

I agree we can just get rid of the check. Will send a PR when I get time sometime tomorrow.

liamuk commented 6 years ago

resolved by merge request