ENH: Create decorator to handle instantiating Shodan object - Githubissues

achillean / shodan-python

The official Python library for Shodan

https://developer.shodan.io

Other

2.51k stars 569 forks source link

ENH: Create decorator to handle instantiating Shodan object #219

Open rmhowe425 opened 4 months ago

rmhowe425 commented 4 months ago

Proposing the idea to convert get_api_key() in shodan.cli.helpers.py to a decorator that retrieves a user's API key and instantiates an instance of shodan.Shodan()

Proposed Implementation:

Proposed changes to existing functionality for get_api_key() shown below.
Add get_shodan_inst() decorator to all Shodan CLI commands.
Add positional api parameter to all Shodan CLI commands.
Remove function call to get_api_key() from Shodan CLI command function bodies.

Benefits:

Significantly reduces redundant code.
Improves overall readability of the code base.