search

achilleasa / dart_amqp

Dart AMQP client implementing protocol version 0.9.1
MIT License
79 stars 40 forks source link

migrate to Dart 2 #17

Closed a14n closed 6 years ago

a14n commented 6 years ago

Those changes make the package compatible with Dart 2.

I disable coverage as the package used to make coverage doesn't work with Dart 2. (btw it could be worth to migrate to coveralls)

achilleasa commented 6 years ago

Merging this PR would break compatibility with dart1.x users right?

What is the recommended way to deal with this? Should we add a note in the README.md that dart1 users should constraint the version of dart_amqp to 0.9.x? If so, would you mind pushing a commit to include this change?

a14n commented 6 years ago

Merging this PR would break compatibility with dart1.x users right?

Not really. In pubspec.yaml the sdk contraints allows to handle dart version. Thus someone with Dart1 will not have access to amqp-0.1.0. Only Dart2 users will see it.

Should we add a note in the README.md that dart1 users should constraint the version of dart_amqp to 0.9.x?

I don't think it's worth to add something in README. It's the normal way to handle SDK constraints