achilleasa / dart_amqp

Dart AMQP client implementing protocol version 0.9.1
MIT License
79 stars 40 forks source link

update/fix lints to use lints/recommended.yaml #54

Closed a14n closed 3 years ago

a14n commented 3 years ago

See https://github.com/dart-lang/lints/

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.2%) to 94.547% when pulling 85a9783fcbb8f2f53537019346c8097b6de30d36 on a14n:update-lints into 68840e17e3b9cb5e5fea70a2e37f1dd6aeabb287 on achilleasa:master.

achilleasa commented 3 years ago

Wow! I was actually working on a branch this very evening to fix all dartanalyzer issues so I could use the null safety migrator tool but you beat me to it by a few hours (was just about to run the tests) :D

In addition to the ones you already fixed have also tackled the 'single quotes instead of double quotes' and the 'missing final for some properties' warnings. I will land your changes and rebase the rest on top.