search

achilleasa / dart_amqp

Dart AMQP client implementing protocol version 0.9.1
MIT License
79 stars 40 forks source link

Pass onBadCertificate handler from connection settings to SecureSocket #57

Closed jrobindb closed 3 years ago

jrobindb commented 3 years ago

Fixes Issue #56.

I am not sure how to properly add a test for this change.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.003%) to 94.333% when pulling 0eb0bc52ef1f1398ac778fbc74e505c34cb928d0 on jrobindb:on-bad-cert into 2541d36b02736f58274c44672c641635d44ad9d1 on achilleasa:master.

achilleasa commented 3 years ago

To test this you can modify this test to pass a bogus certificate (see a few lines above for how to setup a local rabbit instance to use the local test certs) and verify that onBadCertificate gets invoked.

achilleasa commented 3 years ago

@jrobindb Any update on adding a test for this PR? I am preparing to push a new release and it would be great to get this PR landed before that.

jrobindb commented 3 years ago

@jrobindb Any update on adding a test for this PR? I am preparing to push a new release and it would be great to get this PR landed before that.

I am sorry, I don't expect to be able to get to it in the foreseeable future.

achilleasa commented 3 years ago

No worries. I will append a commit for the tests and land this.

achilleasa commented 3 years ago

Closing in favor of #63 which includes this commit plus the missing test.