achimnol / aiotools

Idiomatic asyncio utilties
https://aiotools.readthedocs.io
MIT License
153 stars 11 forks source link

Support Windows #26

Open achimnol opened 3 years ago

achimnol commented 3 years ago

Yes, I just bought a new Windows desktop.

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 (de710d4) into main (17b47b9) will decrease coverage by 13.99%. The diff coverage is 36.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   72.34%   58.34%   -14.00%     
===========================================
  Files          10       13        +3     
  Lines         846     1030      +184     
===========================================
- Hits          612      601       -11     
- Misses        234      429      +195     
Impacted Files Coverage Δ
src/aiotools/compat.py 70.00% <0.00%> (-30.00%) :arrow_down:
src/aiotools/fork_windows.py 0.00% <0.00%> (ø)
src/aiotools/fork.py 76.19% <73.68%> (+29.52%) :arrow_up:
src/aiotools/fork_unix.py 77.04% <77.04%> (ø)
src/aiotools/fork_base.py 77.77% <77.77%> (ø)
src/aiotools/context.py 36.27% <0.00%> (-58.83%) :arrow_down:
src/aiotools/taskgroup.py 89.15% <0.00%> (-1.21%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17b47b9...de710d4. Read the comment docs.

youknowone commented 2 years ago

if this patch will take time, could you consider to merge #47 first?