achirkin / qua-kit

Quick Urban Analysis Kit
MIT License
17 stars 8 forks source link

Exercise editor: support updates #73

Closed mb21 closed 6 years ago

mb21 commented 6 years ago

see https://github.com/achirkin/qua-kit/issues/70

Notes

Questions

achirkin commented 6 years ago

visually, the pages look quite hideous... is that okay for the admin pages, or...?

That's true :-D It would be nice to make it more usable, but only if we have time for that, since it is only visible to a few admins.

ExerciseSettings with key and value columns doesn't appear to be needed since we have the onSubmitMsg and canAddDeleteGeom columns (added by you), as well as the canEditProperties column (added in this pull).

Yeah.. I added it only because I did not have time for a proper solution :) So I still think, it makes sense to put all settings into another table. Let's keep it in mind, but postpone for a while

mb21 commented 6 years ago

okay, then this should be ready to merge.. or should I add some CSS today?