search

achiurizo / consular

Terminal automation
http://rdoc.info/github/achiu/consular/master/file/README.md
MIT License
813 stars 46 forks source link

iTerm2 splitting into panes #76

Closed LevelbossMike closed 13 years ago

LevelbossMike commented 13 years ago

I added functionality to make it possible to split tabs into panes in iTerm2. This resolves #61.

achiurizo commented 13 years ago

could you also include tests for this pull request?

LevelbossMike commented 13 years ago

Sure. I don't know how to test the gui-scripting stuff (that just works in Applescript) but I will include test for my additions to the dsl and iterm-core. But effectively the additions shouldn't break anything and should be ignored by the other cores that don't implement the split_panes. I will make sure though ;)

LevelbossMike commented 13 years ago

unfortunately I am not able to test the iterm-core properly. It always throws errors when i try to test any method that tries to open a new session with the make-command that comes with iterm's Applescript. I guess this has to do with a name conflict with 'make'.

Of course my additions don't break any tests of the other cores or the dsl. And iterm2 behaves as expected.

achiurizo commented 13 years ago

ok thanks, ill take a look and see if i can get it working. this pane feature is something Id like to have also for my iTerm :)

LevelbossMike commented 13 years ago

the pane feature is working already. it's just the tests that don't behave correctly because they won't run if any method is called that makes use of the iterm 'make' appscript-method, for example opening a new session. but maybe it's just me and I don't get Riot ;)

LevelbossMike commented 13 years ago

The problem with split panes in fullscreen is caused by the fact that in fullscreen there's no menu bar one could script to split the panes, I guess. But we could work around that with a fullscreen option that puts iterm into fullscreen mode after it has split all panes. I was planning to work on getting to work the terminal options in iterm anyway with terminitor after the addition of the split-panes support.

achiurizo commented 13 years ago

I've re-added the tests back in and also added you into the README. I would like to test with the other cores to ensure they do work with the changes made in this request before I push out another version.