search

achiurizo / consular

Terminal automation
http://rdoc.info/github/achiu/consular/master/file/README.md
MIT License
813 stars 46 forks source link

panes do not work in latest iTerm2 #86

Closed adamnbowen closed 13 years ago

adamnbowen commented 13 years ago

It seems that the latest update to iTerm2 broke the pane functionality. I don't know if this is a bug in terminitor or iTerm2 though.

Here is the Console.app error:

8/24/11 12:45:05 PM iTerm[5813] Cocoa scripting error for '(null)': four character codes must be four characters long.

8/24/11 12:45:05 PM iTerm[5813] .scriptSuite warning for result type of command 'launch' in suite 'iTerm': the type PTYSession ('Pssn') doesn't match the result Apple event code ('').

If this is a iTerm problem, and not a terminitor problem, let me know, and I'll alert the iTerm people. I have gotten panes to work with the usual keyboard shortcuts, which makes me think there was an API change or something, and terminitor needs to be updated.

achiurizo commented 13 years ago

hmm yeah I do see that. I think this might be terminitor related. I'll need to investigate further. thanks for the heads up. if you have a patch that can fix this issue, i'm more than happy to accept it :)

LevelbossMike commented 13 years ago

This is caused by the fact that iterm has renamed its menu items that are responsible for splitting panes. I am currently updating the iterm core to reflect this change. I hope I can send a pull request today or tomorrow that fixes the issue.

with this everything should be back to normal: https://github.com/achiu/terminitor/pull/88

adamnbowen commented 13 years ago

Thanks @LevelbossMike, glad to see it turned out to be a "simple" issue, rather than some deep incompatibility.

adamnbowen commented 13 years ago

Oh, unfortunately, this issue has popped up again in the latest version of iTerm2 (why do they insist on breaking us?). Here is the console.app error, which seems to be the exact same error @LevelbossMike fixed early September:

10/27/11 10:26:37 AM    iTerm[13121]    Cocoa scripting error for '(null)': four character codes must be four characters long.

10/27/11 10:26:37 AM    iTerm[13121]    .scriptSuite warning for result type of command 'launch' in suite 'iTerm': the type PTYSession ('Pssn') doesn't match the result Apple event code ('').
adamnbowen commented 13 years ago

I won't pretend to have any familiarity with either application, but perhaps the new title feature they have for panes could be the culprit: https://github.com/gnachman/iTerm2/commit/013f253233ea1eae83eaaa6e166d2c2a982552c1

LevelbossMike commented 13 years ago

https://github.com/achiu/terminitor/pull/92 should fix this.

achiurizo commented 13 years ago

I actually did a rewrite of terminitor here. With this, the cores are broken out into their own gems as well and already contain a fix for the panes. You can use the iterm core here. Let me know if that works for you.