search

achorein / expo-share-intent

🚀 Simple share intent in an Expo Native Module
MIT License
119 stars 10 forks source link

refactor: clean TS errors, add TS rules, cmn types #45

Closed ChristopherGabba closed 2 months ago

ChristopherGabba commented 3 months ago

Summary

This is my first PR to an open source project ever, so feel free to shoot down.

  1. Added descriptions to some of the types
  2. Created a common type between them in some instances
  3. Added some additional TSConfig rules used in some big open source projects
  4. Removed all the Typescript warnings within useShareIntent.

Trying to keep this PR small and management because I'm still learning. Feel free to shut down this PR.

Todo

I added some TODO text to the types that eventually would be ideal to clean up and get one common type. I'm not bold enough to mess with the native code yet.

Issue

No Github issues. Just trying to add some comments and be helpful.

achorein commented 2 months ago

@ChristopherGabba I updated this PR, is that fine for you ?