search

achoudh5 / Manipulating_Excel_Sheet

Real world application of Manipulating Excel Sheet using python.
Apache License 2.0
8 stars 14 forks source link

Update zip.py #14

Closed KUndn closed 3 years ago

KUndn commented 3 years ago

imported valid_ip.py as a module and implemented is_valid() function from the module.

achoudh5 commented 3 years ago

Thank you @KUndn for your contribution!

KUndn commented 3 years ago

Thanks

On Sat, 3 Oct, 2020, 12:53 PM Anshul Choudhary, notifications@github.com wrote:

Merged #14 https://github.com/achoudh5/Manipulating_Excel_Sheet/pull/14 into main.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/achoudh5/Manipulating_Excel_Sheet/pull/14#event-3836318497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOUUEMNWYYJIOGHBXXTOMCTSI3GPFANCNFSM4SCPG6KA .

achoudh5 commented 3 years ago

Hi @KUndn

Upon running, it gave me error:-

wb = openpyxl.load_workbook(i) NameError: name 'i' is not defined

Seems like valid_ip.py doesn't know about the variable i you transferred from zip.py

Can you fix it?

KUndn commented 3 years ago

Hi @achoudh5 wb = openpyxl.load_workbook(i) in above statement i is input variable and valid.py doesnot take any input i is not passed from zip.py folder.

that's all i can deduce from what i know, if that's correct i can just uncomment the input statement . Correct me if i am wrong.

achoudh5 commented 3 years ago

Yea, that's correct understanding! Make sure that is_valid function is working maybe use a print statement. If you can paste some output as well that'll simply things for me 😃