search

achoudh5 / Manipulating_Excel_Sheet

Real world application of Manipulating Excel Sheet using python.
Apache License 2.0
8 stars 14 forks source link

Removed unecessary comments and added few function details #16

Closed mohandas-pai closed 3 years ago

mohandas-pai commented 3 years ago

Removed unecessary comments from zip.py and fixed few.

achoudh5 commented 3 years ago

Hi @mohandas-pai

Thank you for contributing, can you please resolve merge-conflicts?

Also, can you add these lines as comment up top:-

#TASKS:-

#Make it neat
##Make script efficient and eliminate complexity
#add comments explaining what has been done
#Apply Datastructures and algorithms where required
#Use OOPs concepts
#Make it pythonic
#use modules if required
mohandas-pai commented 3 years ago

Hi @mohandas-pai

Thank you for contributing, can you please resolve merge-conflicts?

Also, can you add these lines as comment up top:-

#TASKS:-

#Make it neat
##Make script efficient and eliminate complexity
#add comments explaining what has been done
#Apply Datastructures and algorithms where required
#Use OOPs concepts
#Make it pythonic
#use modules if required

Hello, Yes.. will fix the conflict and also add the changes you mentioned

achoudh5 commented 3 years ago

Hey @mohandas-pai

Since, I merged you PR, do we need this PR? If not can you cancel it, I don't like to say it's invalid :)