Created gui.py file - Githubissues

tanya3007 commented 3 years ago

Type the sheet number, browse to the file. The zip.py code will make the changes in the file and display the changed table. Also, a download button to save the file in the same directory as the gui.py script.

achoudh5 commented 3 years ago

Hi @tanya3007

Can you merge it in GUI/dashboard.py ? I kinda want both things on a single pane of GUI if that makes sense. Is it possible for you to work on it?

PS- I haven't looked completely at gui.py yet unless you have already done it! Let me know :)

tanya3007 commented 3 years ago

Shall I delete the current code in dashboard.py and add my code of gui.py into it ? I have written it from scratch, so I do not know, if the code in dashboard.py is useful.

Update :- Or shall I add my code along with the code in dashboard.py?

achoudh5 commented 3 years ago

@tanya3007 Ohh yeah for sure, but why I am focussing on dashboard.py is because I have something in place where I am making an api call and using that search box for that purpose. The search box should take an input like s in dashboard.py , just made changes to GUI/dashboard.py to give you an idea.

Now, if you think you can add that feature in your new gui.py by all means go for it.

Edit: Can you also add requirements.txt for your code, that'll be helpful to me :)

tanya3007 commented 3 years ago

I compiled the code in dashboard.py . Probably, there is some issue in the code. The GUI doesn't shows an input box and a button. Can you figure it out?

Meanwhile, I'l be adding my written code for parsing excel sheet below your code.

achoudh5 commented 3 years ago

Hi @tanya3007

I am not sure why it's giving you error, mine worked fine. Can you paste the error that I can look into ? Also, I made some changes to readme.md to give you an idea.

tanya3007 commented 3 years ago

Hey @achoudh5 . I merged the codes and they are now working fine. Added requirements.txt. Initialdir also fixed. Yes, the files will remain stored as soon as the user selects the excel file until the user terminates the GUI.

The GUI is working fine. I also modified the zip.py and valid_ip.py code a bit to work with the GUI code. Still, there are some other errors in the file zip.py ( not related to the GUI code ). Can you run the zip.py individually giving the parameters in main and figure them out?

Can you review the GUI code?

tanya3007 commented 3 years ago

Apologies. But I am a little bit confused regards the UI. I had a look over the readme file.

Where exactly shall I put the Input and Output sections ? Shall I remove that image ? and put something there?

Also, regarding that Browse File button. Is the error raised just after clicking the button, or after selecting the excel sheet? Actually, It's working fine in mine. Probably, tkinter would be not up to date. Can you check once?

I'll change the colour of the scrollbar.

I am attaching few pictures showing how the UI is looking in my desktop.

Screenshot (338)

Screenshot (339)

achoudh5 commented 3 years ago

Apologies. But I am a little bit confused regards the UI. I had a look over the readme file.

Where exactly shall I put the Input and Output sections ? Shall I remove that image ? and put something there?

Also, regarding that Browse File button. Is the error raised just after clicking the button, or after selecting the excel sheet? Actually, It's working fine in mine. Probably, tkinter would be not up to date. Can you check once?

I'll change the colour of the scrollbar.

I am attaching few pictures showing how the UI is looking in my desktop.

Yeah, remove that image but keep some space for an image there right above check validity box
you can put the Input section on the leftmost side of the GUI i.e. before check validity box and Output section on the rightmost side i.e. right after the check validity box (Check 3(Input) and 4(output) in sample GUI on readme)
Yeah, it's some issue with mac catolina OS for tkinter, your UI looks very impressive. Thanks for attaching the screenshots.
Yes, it'll be great if you can change the color of the scrollbar which goes with the UI of the buttons. Also, if you can change the color of Browse similar to check validity that'll be great :)

Edit: Also, upload a sample picture to corroborate, my tkinter in catalina has some issues and I won't be able to fully see your work!

tanya3007 commented 3 years ago

Ok Sure.

I'll change the colour of Scrollbar, Browse button. For now, I am not removing the image. You can change the image in future, since you have to add some image.

I can make the input section and Image section (consisting of Input box and Checking Validity button) in one line (inline). But the output probably won't look good on the right side, since the columns in the excel sheet are good in number. I am attaching a sample picture showing how the Excel sheet looks.

Screenshot (340)

achoudh5 commented 3 years ago

Ok Sure.

I'll change the colour of Scrollbar, Browse button. For now, I am not removing the image. You can change the image in future, since you have to add some image.

I can make the input section and Image section (consisting of Input box and Checking Validity button) in one line (inline). But the output probably won't look good on the right side, since the columns in the excel sheet are good in number. I am attaching a sample picture showing how the Excel sheet looks.

Actually you are right, how about we just put the check validity button right in line with the browse button pane, align them horizontally and keep some space. Below them, we can have the Output excel file preview, makes sense?
Also, I found Reference you can use to style buttons.

Sample for check validity , this is half done. I want to change the mouse cursor to hand when someone hovers on the buttons and also, like I mentioned about color combination in previous comment.

style = ttk.Style()
style.map("C.TButton",
          foreground=[('pressed', 'red'), ('active', 'blue')],
          background=[('pressed', '!disabled', 'black'),
                      ('active', 'white')]
          )
validity_Button = ttk.Button(second_frame,text="Checking validity!",command= myClick, style="C.TButton")
# canvas1.create_window(280, 180, window=validity_Button)
validity_Button.grid()

Let me know if this makes sense :)

tanya3007 commented 3 years ago

So, first comes the Image. Then below them are the Input sections and check Validity sections. Below that, comes the Output section. Am i right?

Rest, that cursor change, I'll do.

achoudh5 commented 3 years ago

So, first comes the Image. Then below them are the Input sections and check Validity sections. Below that, comes the Output section. Am i right?

Rest, that cursor change, I'll do.

Question: the preview I see in your output is of Hacktoberfest_Inputt.xlsx or after it passes through zip.py :eyes:

That sounds good!

tanya3007 commented 3 years ago

It is just a sample. I told you before, that there are some errors in zip.py, which can you figure out, compiling it individually.

tanya3007 commented 3 years ago

Hey @achoudh5 , I did the changes as per you said, and added in the PR.

Can you review and merge it? I am also attaching a picture of the GUI.

Screenshot (341)

achoudh5 commented 3 years ago

Hey @achoudh5 , I did the changes as per you said, and added in the PR.

Can you review and merge it? I am also attaching a picture of the GUI.

reviewing..

achoudh5 commented 3 years ago

Hey @achoudh5 , I did the changes as per you said, and added in the PR. Can you review and merge it? I am also attaching a picture of the GUI.

reviewing..

Minor fixes:
- When I click, Check Validity button ideally it should print some text (take any sample text to print for your testing) it throws below error
- Error: _tkinter.TclError: cannot use geometry manager grid inside . which already has slaves managed by pack
- [Reference] (https://stackoverflow.com/questions/23584325/cannot-use-geometry-manager-pack-inside)

Rest Very Well done @tanya3007 !! It looks great, one last thing I would love to have is a horizontal scroll bar as well that will simplify user experience :)

tanya3007 commented 3 years ago

Hey @achoudh5 , I did the changes as per you said, and added in the PR. Can you review and merge it? I am also attaching a picture of the GUI.

reviewing..

Minor fixes:

When I click, Check Validity button ideally it should print some text (take any sample text to print for your testing) it throws below error

Error: _tkinter.TclError: cannot use geometry manager grid inside . which already has slaves managed by pack

[Reference] (https://stackoverflow.com/questions/23584325/cannot-use-geometry-manager-pack-inside)

Rest Very Well done @tanya3007 !! It looks great, one last thing I would love to have is a horizontal scroll bar as well that will simplify user experience :)

There is a code in the myClick func( ). < str(s) >in line 133. It is throwing error. You have written there, that it is from some api. so shall I make s="some api" for now?

achoudh5 commented 3 years ago

Hey @achoudh5 , I did the changes as per you said, and added in the PR. Can you review and merge it? I am also attaching a picture of the GUI.

reviewing..

Minor fixes:

When I click, Check Validity button ideally it should print some text (take any sample text to print for your testing) it throws below error

Error: _tkinter.TclError: cannot use geometry manager grid inside . which already has slaves managed by pack

[Reference] (https://stackoverflow.com/questions/23584325/cannot-use-geometry-manager-pack-inside)

Rest Very Well done @tanya3007 !! It looks great, one last thing I would love to have is a horizontal scroll bar as well that will simplify user experience :)

There is a code in the myClick func( ). < str(s) >in line 133. It is throwing error. You have written there, that it is from some api. so shall I make s="some api" for now?

s=<text(probably an email, abcd@gmail.com)> and ingest in

mylabel = Label(root, text=str(counter)+' '+'You Entered:'\ +str(s)+'\nRequestor'+' '+str(s)+'\n')

tanya3007 commented 3 years ago

I didn't got you. What you meant by "ingest in" ? Did you meant use the text which the user enters? If yes, then it is already being used by the code < input_box.get( ) >. Else, if you meant write a sample string for now, I am adding "some api" as the string.

Also, @achoudh5 I tried adding the horizontal scrollbar, but it is having issues. I am not able to position it properly. I am attaching a picture. Probably, we can opt it out?

Screenshot (342)

achoudh5 commented 3 years ago

Yes, use "abcd@gmail.com" rather than "some api". Whatever you use it should be printing that on the GUI under the check validity button! The check validity should work independently and the entries should be in decreasing order. Ex. At 10am you entered abcd@gmail.com and at 6pm you checked for dfgh@yahoo.com then, 6pm entry should be at top followed by 10am entry. Makes sense?
Yeah, horizontal bar can be skipped.

tanya3007 commented 3 years ago

Okay Sure. I made the changes and also marked that thing.

Can you review it?

Screenshot (343)

achoudh5 commented 3 years ago

Reviewing...

achoudh5 commented 3 years ago

Okay Sure.

I made the changes and also marked that thing.

Can you review it?

Are you stretching the image in background or you have kept original image size?
Can we have like a change button where user browse through images in his machine and can change it as well? If this task is daunting we can put on hold!

tanya3007 commented 3 years ago

I have changed the image size, to adjust with the left and right columns, and so that it looks better.

I have added the Change Image button. Probably, after this, it might be daunting. lol 😆

Can you review it?

achoudh5 commented 3 years ago

I have changed the image size, to adjust with the left and right columns, and so that it looks better.

I have added the Change Image button. Probably, after this, it might be daunting. lol 😆

Can you review it?

Haha, I am reviewing this change. I made some comments for the last 2 commits

tanya3007 commented 3 years ago

Heyy @achoudh5 ,

Did the changes. Now the first entered prints first.

Will that be okay with the whole work?

achoudh5 commented 3 years ago

Heyy @achoudh5 ,

Did the changes. Now the first entered prints first.

Will that be okay with the whole work?

reviewing...

tanya3007 commented 3 years ago

Heyy, Probably, You can use images from here. I think I have completed the task given to me. 😄 Yess, I got to learn a lot working on this repo.

Screenshot (345) Screenshot (346) Screenshot (347)

achoudh5 commented 3 years ago

Heyy, Probably, You can use images from here. I think I have completed the task given to me. 😄 Yess, I got to learn a lot working on this repo.

Sounds good! I'll merge it

tanya3007 commented 3 years ago

Hey @achoudh5 , Thanks for merging this. The task was tedious, but definitely learnt a lot!.

Also, I made another PR, and now it's printing in decreasing order. You can merge it.

achoudh5 commented 3 years ago

I made it tedious on fly :P

This is real world scenarios, good luck for your future!

tanya3007 commented 3 years ago

Haha ! Thanks a lot... 🔥

PS:- Don't forget merging that another PR lol. Had a bad timing due to which have to make another. :P

achoudh5 / Manipulating_Excel_Sheet

Created gui.py file #19