search

achoudh5 / Manipulating_Excel_Sheet

Real world application of Manipulating Excel Sheet using python.
Apache License 2.0
8 stars 14 forks source link

Modified valid_ip and added visualize.py #32

Closed DanB288 closed 3 years ago

DanB288 commented 3 years ago

Have added a file to visualise the input excel file and modified valid_ip.py to print in requested format. I've used a scatter plot here, let me know, if you'd like to use any other plot like a heat map or something else.

I apologise for the slight delay in resolving this issue. Thank you for your patience.

achoudh5 commented 3 years ago

@DanB288 can you update the requirements.txt as well ?

DanB288 commented 3 years ago

Sure👍

DanB288 commented 3 years ago

Thanks @achoudh5 for the review , I'll add these changes and get back to you soon👍

achoudh5 commented 3 years ago

Reviewing soon...

DanB288 commented 3 years ago

I've added the rope file as I couldn't rename the variables without it. I'll add the unit tests as a new PR after you've reviewed the visualisation file.

DanB288 commented 3 years ago

Previously, the graph was generated randomly every time we run the program. I've made it constant to a particular format now . If required can change the formation by modifying the value of seed parameter in spring_layout.

DanB288 commented 3 years ago

Yeah , it's similar to .gitignore for python in vscode.