search

achow101 / signapple

MIT License
39 stars 10 forks source link

build: fully remove requests dep #11

Closed fanquake closed 11 months ago

fanquake commented 11 months ago

Otherwise this fails to build.

achow101 commented 11 months ago

With recent versions of pip, it should actually be possible to ditch the setup.py entirely. I'll merge this and play around with removing the setup.py.

achow101 commented 11 months ago

ACK 5aad5b278224a42a2574a3ca93e020e80182151a

fanquake commented 11 months ago

and play around with removing the setup.py.

Just note that if that is removed, we'll likely need to change our package definition in our Guix manifest, to use a different install method. However, that can be dealt with at the bump after next.

achow101 commented 11 months ago

we'll likely need to change our package definition in our Guix manifest, to use a different install method

From https://guix.gnu.org/manual/en/html_node/Python-Modules.html

pyproject-build-system is Guix’s implementation of this standard. It is considered “experimental” in that it does not yet support all the various PEP-517 build backends, but you are encouraged to try it for new Python packages and report any problems. It will eventually be deprecated and merged into python-build-system.

It'll probably be ready for the next release?

fanquake commented 11 months ago

Yea, I don't think it'll be an issue.