search

achrinza / node-ipc

Drop-in fork of `node-ipc`.
MIT License
35 stars 10 forks source link

Update node 18 #32

Closed erg closed 2 years ago

erg commented 2 years ago

Node 18 is out. vue create depends on this library somehow and chokes on node 18.

error @achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.0.0"
error Found incompatible module.

I ran npm test with node 18 and the tests seem to pass. You might have to release a patch release after this.

node --version
v18.0.0
achrinza commented 2 years ago

Thanks for the PR, @erg. Some additional changes are required (e.g. CI matrix, DCO sign-off, correct base branch) of which I've applied in a separate set of PRs.

Closed in favour of https://github.com/achrinza/node-ipc/pull/34 and https://github.com/achrinza/node-ipc/pull/35