search

achyudh / propr-firefox-plugin

This is a Firefox Plugin for Bugzilla and Mozreview to collect data from Mozilla developers when they are reviewing patches in order to determine common features of "good" code changes.
0 stars 2 forks source link

Clicked Submit on Github Pull Request, nothing happened #1

Open chutten opened 6 years ago

chutten commented 6 years ago

I filled in some comments and a review for https://github.com/mozilla/python_moztelemetry/pull/195 then clicked Submit. Nothing happened.

I checked the log, there were only two items in it:

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.
Content Security Policy: The page’s settings blocked the loading of a resource at self (“script-src”). Source: onkeypress attribute on INPUT element.

Maybe the second is relevant? I tried clicking the submit button one or two more times, to no effect (no feedback, no network traffic, no JS running).

Using Propr 1.1

achyudh commented 6 years ago

Hi Chris! Thanks a lot for the bug report. This add-on was actually developed for Bugzilla but I extended it as a stop gap solution to work with GitHub. I noticed multiple errors possibly due to GitHub's Content-Security-Policy not allowing me to send requests to the back-end. I will try fix this error, though I haven't been able to reproduce the error on my end.

There is a GitHub specific version (http://propr.tudelft.nl/) but it requires the owner of the repo to install it.