search

aci-ref / facilitation_best_practices

This repo is deprecated and reinstated/continued at https://github.com/aci-ref/facilitation_leading_practices as of 12 February 2018.
http://aci-ref.github.io/facilitation_best_practices
MIT License
4 stars 11 forks source link

Template and CSS changes, adding icons, and examples in the test chapter page #27

Closed devbioinfoguy closed 7 years ago

lmichael107 commented 7 years ago

Hi Bob,

Lots of work! Given that there are a lot of chapters changed and that we can't follow our usual review process, perhaps you can at least confirm that you tested these changes, visually, in your own GitHub repo of the best practices doc?

devbioinfoguy commented 7 years ago

Yes, previews were done in the images/01-testing-images/ rendered doc in my fork of the repo. All OK there. Style sheet changes only affect elements using the new classes, so no chance of something existing being changed.

I did catch one minor glitch: if chapters didn't have the keyword 'icon' with a filename defined in the YAMP, then a broken image placeholder appeared next to the chapter title. I made that icon code conditional in the _layout/chapter.html, so when the icon is put in, the chapter title will appear changed. Otherwise, it is unaltered.

In total, only css/main.css and _layouts/chapter.html changed. Icon files added to images/, and images/01-testing-images.md changed.

-Bob

ChristinaLK commented 7 years ago

This looks good to me. Should I go ahead and merge?

lmichael107 commented 7 years ago

yes! -L

Lauren Michael - Research Computing Facilitator, Center for High Throughput Computing http://chtc.cs.wisc.edu/, University of Wisconsin - Madison Other Affiliations: Advanced Computing Initiative http://aci.wisc.edu/; Wisconsin Institute for Discovery http://wid.wisc.edu/profile/lauren-michael/; ACI-REF http://aci-ref.org/ lmichael@wisc.edu, www.tinyurl.com/LMichaelCalendar, Discovery 2262, 608.316.4430

On Tue, Jun 27, 2017 at 9:19 AM, Christina Koch notifications@github.com wrote:

This looks good to me. Should I go ahead and merge?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aci-ref/facilitation_best_practices/pull/27#issuecomment-311373028, or mute the thread https://github.com/notifications/unsubscribe-auth/ADmlRBMZ39oL_KweXyc3CF8Z57iwwLPBks5sIQ-EgaJpZM4OEv66 .