Final touches - Githubissues

acid-info / guide.logos.co

Logos Brand Guidelines

https://logos-brand-guidelines.vercel.app

0 stars 1 forks source link

Final touches #28

Open amirhouieh opened 8 months ago

amirhouieh commented 8 months ago

[x] LSD overview page should include a link to LSD repo as well as NPM
[ ] LSD figma link should point to Figma community page
[x] In this page LSD in title should not be a link. If we need to make a link it should be part of the text. In the same page the the image includes buttons for "theme adjustment" etc... this is redundant, lets remove them.
[x] LSD/tokens/colors Theme font switch is redundant
[x] LSD/tokens/colors Theme font & Theme color switches are redundant

jongomez commented 8 months ago

The first 2 points are in the following PR - it's still a draft because I don't know the npm link and the figma community link:

https://github.com/acid-info/logos-brand-guidelines/pull/29

The last 3 points you mentioned were implemented in the following PR:

https://github.com/acid-info/logos-brand-guidelines/pull/25

The image with the buttons has been replaced with the actual Typography storybook component.

nireims commented 7 months ago

The 'download' buttons are supposed to download the assets, but currently, they just open images in a new tab

nireims commented 7 months ago

Grid and Layout -> Web environment

The button group shouldn't be here

Examples should be in a two-column layout https://www.figma.com/file/SaEMNg8YI0IFU1CVXFaRwE/Brand-Guidelines-UI?type=design&node-id=56%3A14292&mode=design&t=wjBZ26nLkL0u5R4p-1

nireims commented 7 months ago

LSD -> Spacing tokens

Is it possible to reduce spacing from the page title to the content?

nireims commented 7 months ago

Grid and Layout -> Non-web environment

Update images on the page https://www.notion.so/Non-web-environment-97ad082daad4481c97c3b289436f8a74