search

acid-info / logos-press-engine

Logos Press Engine website
https://press.logos.co
0 stars 0 forks source link

Basic LightBox component for article images #197

Closed jongomez closed 1 year ago

jongomez commented 1 year ago

Creates a basic version of the LightBox component for all images in an LPE article.

It was heavily inspired by: https://github.com/acid-info/logos-docusaurus-plugins/blob/964bf92263cf6eb61527c92c83c73ab6ba74e36d/packages/logos-docusaurus-theme/src/client/containers/LightBox/LightBox.tsx

The main differences are:

Video 1 - desktop:

https://github.com/acid-info/logos-press-engine/assets/9993816/afc8bab7-2002-414f-9f5d-c7086deb95c6

Video 2 - mobile with pinch zoom:

https://github.com/acid-info/logos-press-engine/assets/9993816/1c5d2bfd-e18c-4e3b-8161-49dbd16084e3

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lpe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:07pm
jeangovil commented 1 year ago

@jongomez, thanks for the great work,

jongomez commented 1 year ago

@jeangovil thanks for the review. I agree with all your suggestions. Will implement them asap.

Are you planning to implement the missing functionalities(carousel, the caption on the bottom, etc.) in another PR?

From what Amir told me, at the moment we're only looking for similar functionality to the vac.dev website. However, if people think it makes sense to have a fully fledged LightBox component - then yes, I'd love to work on that.

jeangovil commented 1 year ago

From what Amir told me, at the moment we're only looking for similar functionality to the vac.dev website. However, if people think it makes sense to have a fully fledged LightBox component - then yes, I'd love to work on that.

Alright then, wasn't aware of that, let's keep it as is.