acidanthera / bugtracker

Acidanthera Bugtracker
386 stars 45 forks source link

Why in Sample.plist parametr FuzzyMatch setted not like Failsafe value in documentation? #2173

Closed Drovosek01 closed 1 year ago

Drovosek01 commented 1 year ago

In official documentation for latest release OpenCore (v0.87) https://github.com/acidanthera/OpenCorePkg/blob/10fc98fc5dd1fa569e988e0aef9ffe8e88ea74c7/Docs/Configuration.pdf for parametr FuzzyMatch failsafe value is false: image

but it Sample.plist with same verion release parametr FuzzyMatch has value true. image https://github.com/acidanthera/OpenCorePkg/releases/tag/0.8.7

Questions:

  1. Failsafe value from documentation !== default value in default config?
  2. If answer on first question is "yes", then why default config have not failsafe values?
Drovosek01 commented 1 year ago

Same for parametr EnableWriteUnprotector

PMheart commented 1 year ago

Answers:

  1. We renamed "default" to "failsafe" many years ago, so you are correct.
  2. Our sample config is not a reflection of the failsafe values.
dreamwhite commented 1 year ago

I think users must check every single key they don't understand and check whether they need it or not. As @PMheart stated, Sample.plist isn't a reflection of the failsafe values, and - I wanna add - must be tweaked according to your needs.

Drovosek01 commented 1 year ago

Answers:

  1. We renamed "default" to "failsafe" many years ago, so you are correct.
  2. Our sample config is not a reflection of the failsafe values.

Thank you for the answers. Please add this info in OpenCore documentation

PMheart commented 1 year ago

Not necessarily in my opinion - every user should refer to Configuration.pdf when setting up config.plist, while Sample[Custom].plist is not a necessity.

Drovosek01 commented 1 year ago

Not necessarily in my opinion - every user should refer to Configuration.pdf when setting up config.plist, while Sample[Custom].plist is not a necessity.

OK, in this case, please add the Failsafe.plist file to future releases, in which all parameters will be filled with failsafe values from the documentation. I think it will be convenient.

PMheart commented 1 year ago

All failsafe values are clearly visible in Configuration.pdf, hence no need to maintain one more document.