Two bugs in ReloadPciRom - Githubissues

acidanthera / bugtracker

Acidanthera Bugtracker

385 stars 44 forks source link

Two bugs in ReloadPciRom #2235

Open mikebeaton opened 1 year ago

mikebeaton commented 1 year ago

I haven't hit these bugs as in been affected by them, but have been tracing through this code and spotted two errors:

https://github.com/acidanthera/OpenCorePkg/blob/master/Library/OcDeviceMiscLib/ReloadOptionRoms.c#L144 should be checking DecompressedImageBuffer
https://github.com/acidanthera/OpenCorePkg/blob/master/Library/OcDeviceMiscLib/ReloadOptionRoms.c#L170 LoadROM is not set to TRUE for non-compressed ROMs - I believe should be?

mikebeaton commented 1 year ago

I should be able to test a fix for #2 above in due course. Will make a PR.

mikebeaton commented 1 year ago

The first of these is still in what seems to be the original code:

https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c#L305