search

acidanthera / bugtracker

Acidanthera Bugtracker
374 stars 42 forks source link

audk does not apply Uncrustify on commit, and has at least some crusty files #2345

Open mikebeaton opened 8 months ago

mikebeaton commented 8 months ago

While working on https://github.com/acidanthera/OpenCorePkg/pull/498 I noticed that https://github.com/acidanthera/audk/blob/master/MdePkg/Library/BasePeCoffLib2/PeCoffInit.c at least (and probably some other files) fails Uncrustify.

I'm not sure whether EDK-II files in general currently pass Uncrustify tests (as opposed to Microsoft Project Mu)? If so, then it would be an oversight that some audk files don't.

Naively applying the OpenCore Uncrustify workflow to audk (fork), seems to break Uncrustify before it completes - apparently an Uncrustify bug: https://github.com/mikebeaton/audk/actions/runs/6748885330/job/18348152462