search

acidanthera / bugtracker

Acidanthera Bugtracker
374 stars 42 forks source link

Possible issue with `AppleXcpmCfgLock` Quirk #2355

Open 5T33Z0 opened 7 months ago

5T33Z0 commented 7 months ago

OpenCore build: https://github.com/dortania/build-repo/releases/download/OpenCorePkg-a1a8bd6/OpenCore-0.9.7-RELEASE.zip macOS: 14.2 (23C64) System: Lenovo T490 (Whiskey Lake)

I accidentally disabled AppleXcpmCfgLock in my config.plist and saved it but the system still boots without iit. This surprised me, since it doesn't have an option to disable CFG-Lock in the BIOS.

Since I bought this thing used, I wondered if someone has flashed a custom firmware maybe, so I checked if the MSR 0xE2 register is unlocked – but it isn't:

08222241

So, I dont know if the switch for enabling/disabling the quirk is not working or if something changed in macOS.

Log: opencore-2023-12-08-231055.txt.zip

AlexFullmoon commented 6 months ago

Can confirm, same output of ControlMsrE2 on Thinkpad X1 Yoga 5, macOS 13.6.2, OC 0.9.7, BIOS v.1.33. I can boot with both CfgLock quirks disabled. Haven't tested for long-term system stability, though.

5T33Z0 commented 6 months ago

Can confirm, same output of ControlMsrE2 on Thinkpad X1 Yoga 5, macOS 13.6.2, OC 0.9.7, BIOS v.1.33. I can boot with both CfgLock quirks disabled. Haven't tested for long-term system stability, though.

I see your notebook uses a 10th Gen mobile Intel Core CPU. Maybe newer mobile Intel CPUs don't use the MSR 0xE2 register. Or maybe it's a Lenovo thing?

jozews321 commented 5 months ago

I just got a T490s and I can boot with CFG Lock enabled and without AppleXcpmCfgLock. Is there a way to check for CFG Lock within macOS?

antoniomcr96 commented 3 months ago

https://github.com/acidanthera/bugtracker/issues/1751 The situation is the same for me (Thinkpad L390, Whiskey Lake CPU). I haven't found any valid explanation, though. It simply works

amardikamahdi commented 3 months ago

+1 on this.

Im using Asus K413FQ, with the Intel Core i5-10210u, boot normally even without AppleXcpmCfgLock and AppleCpuPmCfgLock enabled, and CFG Lock absolutely enabled (You can just write my laptop type, and check the bios .bin files, i have tried to check all bios versions of this laptop).

Just curious, if its the case, should i use CPUFriend instead to achieve Power Management? But IOReg shows that X86PlatformPlugin exists tho. Kinda worried about the PM.

Edited:

Asus K413FQ, BIOS version 304, Opencore 0.9.9, Ventura 13.6.6, will be more than happy if any debug logs are required, dont hesitate to ask, will provide as soon as i can.

mackonsti commented 2 weeks ago

Hi everyone, per the PDF configuration manual of OpenCore for AppleCpuPmCfgLock in section 7.8 Quirks Properties:

Note: AppleIntelCPUPowerManagement.kext is removed as of macOS 13. However, a legacy version can be injected and thus get patched using this quirk.

If you are all using Ventura 13.x or later, I believe you can safely close this ticket. Besides, per the same OpenCore manual, AppleXcpmCfgLock is only applicable to MacOS X 10.8 (not required for older).

5T33Z0 commented 2 weeks ago

@mackonsti

You are referencing a different scenario and a different Quirk. As far as AppleXcpmCfgLock is concerned, the manual actually says: "Requirement: macOS 10.8 (not required for older)" which means, that it is required for macOS 10.8 and newer, in cases where macOS cannot write to the PKG_CST_CONFIG_CONTROL MSR register. This is the case if you cannot disable CfgLock in BIOS/UEFI.