search

acidanthera / bugtracker

Acidanthera Bugtracker
385 stars 45 forks source link

New AMD IGPU detection in Lilu breaks GCN 5 (Vega) IGPU detection #2424

Open VisualEhrmanntraut opened 3 months ago

VisualEhrmanntraut commented 3 months ago

revert it

ExtremeXT commented 3 months ago

+1 AMD Ryzen iGPUs are not detected properly anymore.

alvindimas05 commented 3 months ago

I rather commit suicide than commit this update

EAZYBLACK commented 3 months ago

it doesnt boot anymore with this commit on amd ryzen igpu

vit9696 commented 3 months ago

Could you please provide more details on what exactly happens on which platforms?

Also, isn't @Zormeister one of your contributors and wasn't the change coordinated with the patches for the drivers?

vit9696 commented 3 months ago

references https://github.com/acidanthera/Lilu/pull/97

alvindimas05 commented 3 months ago

Could you please provide more details on what exactly happens on which platforms?

Also, isn't @Zormeister one of your contributors and wasn't the change coordinated with the patches for the drivers?

Tested on AMD hack with AMD iGPU and can't boot at all.

vit9696 commented 3 months ago

Sorry, but this is not a support forum, but a bugtracker. Here we require more specific information on the issue. IORegistryExplorer dump would be a good start along with the hardware information.

VisualEhrmanntraut commented 3 months ago

@vit9696 That person has left our team since a month ago so these changes were not co-ordinated on our part. These changes make the iGPU not get detected at all (videoBuiltin is null) at least not the Vega (GCN 5) ones.

vit9696 commented 3 months ago

Right, will it make sense to revert the change and let you rework the patch as needed if at all?

VisualEhrmanntraut commented 3 months ago

These changes currently only make sense for detecting the older iGPUs and not these ones and their successors, as the current code was working fine. As such, currently, it is not our responsibility to support them. I guess you should revert the changes for now and probably contact Zormeister for further elaboration on what to do for legacy AMD iGPUs on this matter.

vit9696 commented 3 months ago

I reverted the change for now. @Zormeister, could you please provide a V2 for the patch so that it does not break the existing setups please?

Zormeister commented 3 months ago

working on fixing it

vit9696 commented 3 months ago

@VisualEhrmanntraut, @alvindimas05, @ExtremeXT, @EAZYBLACK, please review https://github.com/acidanthera/Lilu/pull/98.

alvindimas05 commented 3 months ago

@VisualEhrmanntraut, @alvindimas05, @ExtremeXT, @EAZYBLACK, please review acidanthera/Lilu#98.

Alright, it's working for me now.

Zormeister commented 3 months ago

i confirmed that this also works on my own machine, i didn't deploy the V1 builds to it, only to the Legacy system originally.

Vuxoni commented 3 months ago

Working on my machine too, without problems.

Sooly890 commented 3 months ago

Working on my machine, no issues.