search

acidanthera / bugtracker

Acidanthera Bugtracker
385 stars 45 forks source link

ACPI patches match normalized IDs #2446

Open mhaeuser opened 1 week ago

mhaeuser commented 1 week ago

When the quirk NormalizeHeaders is enabled, IDs matched by ACPI -> Patch are compared to the normalized IDs. This is undocumented, the normalization algorithm is not detailed and normalized IDs appear to not be printed in the log. While it might make sense to preserve the current behaviour and adjust the documentation, I'm not sure anyone really relies on this over just using the wildcard. It is worth noting that toggling the quirk will break or restore the affected ACPI patches for no obvious reason.

Initially reported by CorpNewt.

mhaeuser commented 6 days ago

Interestingly, the initial code worked as expected: https://github.com/acidanthera/OpenCorePkg/commit/7f528ca6eb70e8fa5c8dd2e8d8447e2c589d606c#diff-2dac234d8b20e76b94e408613d05c5d32dea3af9a0361b2a73cd5d1e63c1335cR153-R165

The bug was introduced by: https://github.com/acidanthera/OpenCorePkg/commit/f604848c61d7082860fceb23ac54d5e03e620478#diff-64f173a3dceca8c36f31ffc4f0ea07e76136fdc048dc52a7f23406f41b3d6192R245