search

acidburn0zzz / ics-openvpn

Automatically exported from code.google.com/p/ics-openvpn
1 stars 0 forks source link

Proposal for build process/including executables #197

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
A) I found out that all files that have the form lib*.so and are included in 
the libs folder are automatically deployed on install of an app and have the 
exec flag set.

See https://github.com/dschuermann/root-commands#binaries

I don't want to propose the library, but the method on how to include the 
executables. This makes manual deployment in VPNLaunchHelper obsolete. The 
build-in deployment of libs is also much more reliable than copying from assets 
based on file postfix matching cpu arch.

B) You could then also streamline your build process by requiring Gradle and 
using a Gradle task like I did in AdAway: 
https://github.com/dschuermann/ad-away/blob/master/AdAway/build.gradle#L64
This would make build-native scripts obsolete.

Original issue reported on code.google.com by domschuermann@gmail.com on 4 Sep 2013 at 12:17

GoogleCodeExporter commented 9 years ago 
A)
Thanks for bringing that to my attention. I know that the manual deployment of 
VPNLaunchHelper is not ideal. 

Thanks for discovering this. I will look into it. But as of know I will 
probably stick to my manual deployment of executables to assets since I know it 
works. I already putting all code into the library part so I don't have to 
deal/care about updating these minivpn binaries.

Don't understand me wrong. I like the idea but at the moment a bit 
catious/coward/lazy to see if the "executable bit is set" is always true for 
all platforms/Android version.

I could however rename my minivpn to minivpn.so and just copy that to chache to 
always have the right architecture.

B)
I will probably incoperate something like your "task renameExecutables" in my 
gradle which will replace the buildnative script.

Original comment by arne@rfc2549.org on 4 Sep 2013 at 12:37

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
"I could however rename my minivpn to minivpn.so and just copy that to chache 
to always have the right architecture."
Sure, nice idea.

In AdAway the misuse of libs deployment for executables is working very well :D

Original comment by domschuermann@gmail.com on 4 Sep 2013 at 12:44

GoogleCodeExporter commented 9 years ago 
I think I will stick with my way until it breaks (:

Original comment by arne@rfc2549.org on 2 Jul 2014 at 1:16