Add certain routes in client config file will cause OpenVPN crash(Always repro!)

Summary:
=======
We added following part in client config file hoping we can bypass VPN for 
certain IP addressess:

route 42.0.0.0 255.0.0.0 net_gateway
route 43.0.0.0 255.0.0.0 net_gateway

The crash/exception appears from NetworkSpace.java while it is trying to 
validate/merge IP addresses, but however I could not figure out why adding sub 
subnet will cause APP crash.

What steps will reproduce the problem?
======================================
1.Use attached config file and import to your mobile address, no additional 
configuration is required as I already merge certificate and my testing server 
is online for your debug.
2.Trying to connect
3.App will crash 

What is the expected output? What do you see instead?
=================================================
The expected result should be following routes will be added to mobile device:
route 42.0.0.0 255.0.0.0 net_gateway
route 43.0.0.0 255.0.0.0 net_gateway

However OpenVPN app will crash immediately, if I comment out above, everything 
will be fine.

What mobile phone are you using?
==============================
I tested on GALAXY Note II (N7100) / android 4.1.1  and several other devices, 
it appears it crashes on all the devices.

Which Android Version and stock ROM or aftermarket like cyanogenmod?
===========================================
android 4.1.1

Please provide any additional information below.
================================
The crash is from NetworkSpace:

        if (BuildConfig.DEBUG) {
                        Assert.assertTrue(currentNet.networkMask < nextNet.networkMask);
                        Assert.assertTrue (nextNet.getFirstAddress().compareTo(currentNet.getFirstAddress()) == 1);
                        Assert.assertTrue (currentNet.getLastAddress().compareTo(nextNet.getLastAddress()) != -1);
                    }

This is the deepest place I can go, can you please help why it will crash? Or 
do we have some standards for ip subnets? Thanks!

Original issue reported on code.google.com by hwdzw...@gmail.com on 4 Jul 2014 at 6:15

Attachments:

repro_crash_config_file.ovpn

acidburn0zzz / ics-openvpn

Add certain routes in client config file will cause OpenVPN crash(Always repro!) #263