search

acidcoke / Grimassist

Control your computer by making faces
Apache License 2.0
3 stars 1 forks source link

Inno6 installer #1

Closed acidcoke closed 11 months ago

acidcoke commented 11 months ago

@willwade I took the liberty to create a fork of gameface since I was unhappy with googles way of handling projects. I hope you are okay with this PR.

willwade commented 11 months ago

We have an ev signing certificate. Happy to sign it - it's not doable under GH Actions to sign but on release we can

acidcoke commented 11 months ago

That sounds great.

I have never worked with implementing installers before though, so I will take some time to properly review this PR

willwade commented 11 months ago

It's pretty easy. There's inno6 or nsis. I went with inno6 for this only because I was having a headache with file paths. Note the big change to the source was putting file path locations in readable places under windows 10/11. It's not reliable now to put stuff just in program files.

willwade commented 11 months ago

looks good to me now. Want me to resolve conflicts?

acidcoke commented 11 months ago

Looks perfect now. Thanks, but I'd like it do do myself.

willwade commented 11 months ago

@acidcoke -ive updated the release installer build with our signed version - just nudge me for any others as and when :)