search

acidjazz / drmon

Draconic Reactor computercraft monitoring and failsafe interface
60 stars 84 forks source link

Fix for 15# #33

Open Serverfrog opened 4 years ago

Serverfrog commented 4 years ago

Added changes from https://github.com/acidjazz/drmon/issues/15#issuecomment-331012198

spannerman79 commented 4 years ago

No - this will need ot be put into a difference branch and then later master changed accordingly.

There are those that still play 1.7.10 - and it would be ignorant and arrogant to assume otherwise.

Serverfrog commented 4 years ago

@spannerman79 sorry i didn't know that this little change (a forced to string was never a problem in my world) breaks compatibility with older versions. But without it`s breaking the current versions! Beside that, nothing like this is ever mentioned in the Issue, so please add this if that this change is breaking the compatibility with 1.7.10.

If there are codebases for different Versions then they should be a detection of Versions and correct choosing of the correct codebase