added custom color props for primary and secondary toast buttons

acidjazz / tv-toast

Programmatic toasts for Nuxt.js powered by Tailwind CSS

MIT License

116 stars 11 forks source link

added custom color props for primary and secondary toast buttons #22

Closed SandraRodgers closed 3 years ago

SandraRodgers commented 3 years ago

This is an attempt to add the enhancement requested in Issue 21 (https://github.com/acidjazz/tv-toast/issues/21). If this isn't the best way to fix this, I would be happy to take feedback and try again.

acidjazz commented 3 years ago

@SandraRodgers Thanks for the PR! I'll look it over and test it ASAP

SandraRodgers commented 3 years ago

@acidjazz Great! By the way, it's a great component. Very clean and easy to use.

acidjazz commented 3 years ago

This looks great so far, I wonder if we could:

[x] move the other classes that style the button into this ( the focus classes and active:bg-gray-50)
[x] if we could have these classes stack w/ what you pass through, so that you can style it w/out having to specify all of them.

SandraRodgers commented 3 years ago

Ok, I have attempted to make the classes 'stackable' like you suggested. I wasn't sure about names for the props so you might want to change those (or tell me what to change them to).... I tried not to make them too long but still understandable regarding the type of toast (single action or multiple). Also, I had forgotten to add the props for the single action toast so added that in this commit. Let me know if you have any other suggestions to make this better!

acidjazz commented 3 years ago

@SandraRodgers names are great! this looks good so far, I'll run through it and test stuff ASAP!

acidjazz commented 3 years ago

@SandraRodgers BTW I actually went back to your simpler setup realizing stacking isn't as realistic as I thought, i added some detail in the readme to let people know what defaults will be swapped out.

SandraRodgers commented 3 years ago

That's good, I liked the stacking idea but I can see how having just one prop for each button might be more straightforward for someone looking to style the buttons. Happy I was able to contribute!