n_harmonics=100 - Githubissues

acids-ircam / ddsp_pytorch

Implementation of Differentiable Digital Signal Processing (DDSP) in Pytorch

Apache License 2.0

451 stars 56 forks source link

n_harmonics=100 #26

Closed Seungwoo0326 closed 3 years ago

Seungwoo0326 commented 3 years ago

According to the paper, I think the hyperparameter, model.n_harmonic should be 100 because you already project hidden dimension to n_harmonic + 1 in the harmonic part.

caillonantoine commented 3 years ago

You're right ! But for 16kHz audio, 100 harmonics is overkill anyway, since only signals with a fundamental frequency under 80Hz would need all of them. Furthermore I don't think it would make a great difference :)

Seungwoo0326 commented 3 years ago

Yes, I also agree that It would not make a great difference. But it was good to know the reason why you didn't care about it. Thank you for sharing your insights!

caillonantoine commented 3 years ago

You're welcome ☺️