acids-ircam / pytorch_flows

Implementation and tutorials of normalizing flows with the novel distributions module
GNU General Public License v3.0
160 stars 17 forks source link

in affine transforms, wrong order in matmul? #3

Open colobas opened 5 years ago

colobas commented 5 years ago

Hey I've been playing with the classes you define in your notebooks, and it seems to me that in the affine transformations you're multiplying weights and z in the wrong order. I changed it in my implementation to: (self.weights @ z.unsqueeze(-1)).squeeze(-1) , and made the appropriate change in the _inverse method too