acids-ircam / rave_vst

Other
184 stars 28 forks source link

Fix var-to-String conversion errors for Windows #26

Closed usdivad closed 1 year ago

usdivad commented 1 year ago

Building on Windows currently fails with errors such as:

D:\a\rave_vst\rave_vst\source\ui/ModelExplorer.h(207,1): error C2440: '<function-style-cast>': cannot convert from 'const juce::var' to 'juce::String' [D:\a\rave_vst\rave_vst\build\rave-vst.vcxproj]
D:\a\rave_vst\rave_vst\source\ui/ModelExplorer.h(207,1): message : No constructor could take the source type, or constructor overload resolution was ambiguous [D:\a\rave_vst\rave_vst\build\rave-vst.vcxproj]

This PR fixes those errors by using the juce::var::toString() method instead of passing the juce::var directly to the juce::String constructor in ModelExplorer::selectedRowsChanged().

Successfully built + run locally on Windows, macOS, and Ubuntu.