acik-kuran / acikkuran-api

Açık Kuran API
https://acikkuran.com
Other
141 stars 9 forks source link

Page number ile çağırılan sayfada başka sayfanın datasının gelmesi #14

Open Kemal-Kasap opened 7 months ago

Kemal-Kasap commented 7 months ago

https://api.acikkuran.com/page/604 and 602 and 600 and 598 is wrong when you go to page 604 it takes wrongly 603 and 604 not only 604 602 it takes wrongly 601 and 602 not only 602 600 it takes wrongly 599 and 600 not only 600 598 it takes wrongly 596,597 and 598 not only 598

sametcodes commented 6 months ago

This is not an issue. Page number on the API should be considered as index, and it starts from 0. That means 603 on the API is the page 604, and 602 is 603 and so on.

ziegfiroyt commented 6 months ago

@sametcodes thinking of page numbers as index in the classical sense wouldn't be very accurate. in all qurans that i've seen, including diyanet's, i see the first page as page 0 or it's referred to as the opening. so, approaching it like an index wouldn't be quite accurate. but i understand what @Kemal-Kasap meant, and upon checking, it does seem like a bug to me as well. i'll investigate why verses from page 603 are coming up in the query for page 604, and i'm adding this to my todo list.

Kemal-Kasap commented 6 months ago

For example https://api.acikkuran.com/page/602 Why 601 and 602 was showed togetger. Sadece 602 gelmiyor 601 ve 602 beraber geliyor

19 Nis 2024 Cum 19:47 tarihinde Samet @.***> şunu yazdı:

This is not an issue. Page number on the API should be considered as index, and it starts from 0. That means 603 on the API is actually refers to the page 604, and 602 is 603 and so on.

— Reply to this email directly, view it on GitHub https://github.com/ziegfiroyt/acikkuran-api/issues/14#issuecomment-2066934735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJCGAS7GBHWYF7P73HF653Y6FDDVAVCNFSM6AAAAABFRITVYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHEZTINZTGU . You are receiving this because you authored the thread.Message ID: @.***>