acikyazilimagi / deprem-yardim-backend-go

Apache License 2.0
288 stars 56 forks source link

bug: Disable external access to default ports at docker settings #111

Closed Ahmet-Kaplan closed 1 year ago

Ahmet-Kaplan commented 1 year ago

Error Description

We should not open default ports such as 5432, 6379, 9092 to internet for security purpose.

-- Add this info: ** discord username: Ahmet Kaplan#8742

Error Environment

deprem yardim backend

Describe how you got the error step by step

When docker was deployed, default ports for the programs such as Postgresql, Redis or Kafka are open to access.

Expected Behaviour

All ports except 80 and 443 should be disabled to access.

Desktop Environment

Mac m1 pro

Additional Context

In order to secure that, two docker network should be defined. Those names can be web and internal. Then we assign proper networks to services.

mstrYoda commented 1 year ago

We are not exposing any port other than applications default tcp listener.

You might be confused because of docker compose file. It is only for local development purpose.