acikyazilimagi / deprem-yardim-frontend

release canditate: https://rc.afetharita.com/
https://afetharita.com/
Apache License 2.0
896 stars 283 forks source link

bug: No data with custom filters when the browser refreshed #1102

Closed sercanerhan closed 1 year ago

sercanerhan commented 1 year ago

Bug Definition

A clear and short text to decribe the bug.

When refreshing the browser or accessing a shared Afet Harita link with a custom filter, the locations of victims and heatmaps are not displayed.

Please add discord contact information

discord username: @sercanerhan#0543

 Bug environment

Describe the environment produces the bug. For example: [x] rc.afetharita.com [ ] afetharita.com

Describe how you are producing the bug step by step

  1. Go to the link
  2. Ensure the the Markers & Heatmap is enabled
  3. Bug appears

Alternative method

  1. Go to RC
  2. Zoom to a location where at least a clear marker is visible
  3. Change filter for the services and enable only one of them
  4. refresh the browser
  5. bug appears

Expected Behaviour

A clear and short text to decribe the expected behaviour.

Screen shots

If possible, add screenshots to describe your bug.

image

ezgif com-resize

Desktop Information

Mobile Phone Information

Additional Context

Add any other context about the bug here

fdemir commented 1 year ago

it seems an expected behavior. Should be tested.

usirin commented 1 year ago

@sercanerhan can you retest this, i have a feeling this might be invalid after data fixes

sercanerhan commented 1 year ago

@usirin still same...

usirin commented 1 year ago

probably not fixed but, we made another deployment to rc with #1146 which has a change that uses english-only characters in the url (eg barinma instead of barınma)

oguzergul commented 1 year ago

this works @sercanerhan approved. i am closing.